[PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers
Alexander Popov
a13xp0p0v88 at gmail.com
Wed Nov 20 17:49:08 EST 2013
2013/11/15 Gerhard Sittig <gsi at denx.de>:
> As for the not yet addressed feedback: From the top of my head I
> can think of the execute comment which contradicts the code
> (which suggests that at least one of them is wrong), and the data
> type mismatch in the config routine (where code just happens to
> work by coincidence). And in bypassing I noticed that your
> recent submission has coding style issues (braces, indentation),
> which should no longer happen after several iterations as you
> should know how to prepare and check the next version.
I'll doublecheck this and return with improved code.
> Without feedback, reviewers
> may see several submissions which suffer from the same issues,
> and expect more to show up and thus feel that their feedback is
> getting ignored. Which quickly becomes tiring.
Thanks for your patience and comprehensive replies.
Best regards,
Alexander.
More information about the Linuxppc-dev
mailing list