[RFC] possible null dereference in 'pm121_create_sys_fans()'

Geyslan Gregório Bem geyslan at gmail.com
Mon Nov 18 06:10:27 EST 2013


Hello Benjamin,

In file 'windfarm_pm121'.c:

If this branch is true:

    if (param == NULL) {
        printk(KERN_WARNING "pm121: %s fan config not found "
               " for this machine model\n",
               loop_names[loop_id]);
        goto fail;
    }

control that is NULL will suffer a dereference attempt:

fail:
    /* note that this is not optimal since another loop may still
       control the same control */
    printk(KERN_WARNING "pm121: failed to set up %s loop "
           "setting \"%s\" to max speed.\n",
           loop_names[loop_id], control->name);


Reported-by: Geyslan G. Bem <geyslan at gmail.com>

-- 
Regards,

Geyslan G. Bem
hackingbits.com


More information about the Linuxppc-dev mailing list