[PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes

Varun Sethi Varun.Sethi at freescale.com
Fri Nov 15 14:16:53 EST 2013


Haiying/Scott,
Forgot to mention this, the PAMU driver has to handle stash destination settings both for power and dsp cores (on B4 platform). For the dsp cores we would expect the physical core id (not controlled by Linux). To make the interface consistent, I would expect the caller (for iommu_set_attr) to pass the physical core id.

Regards
Varun

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, November 15, 2013 3:40 AM
> To: Wang Haiying-R54964
> Cc: joro at 8bytes.org; iommu at lists.linux-foundation.org; linuxppc-
> dev at lists.ozlabs.org; Sethi Varun-B16395
> Subject: Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the
> matched cpu nodes
> 
> On Thu, 2013-11-14 at 14:30 -0500, Haiying Wang wrote:
> > In the case we miss to bring up some cpus, we need to make sure we can
> > find the correct cpu nodes in the device tree based on the given
> > logical cpu index from the caller.
> >
> > Signed-off-by: Haiying Wang <Haiying.Wang at freescale.com>
> > ---
> >  drivers/iommu/fsl_pamu.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index
> > cba0498..a9ab57b 100644
> > --- a/drivers/iommu/fsl_pamu.c
> > +++ b/drivers/iommu/fsl_pamu.c
> > @@ -539,6 +539,7 @@ u32 get_stash_id(u32 stash_dest_hint, u32 vcpu)
> 
> Should probably also s/vcpu/cpu/g as vcpu makes no sense outside of
> virtualization code.
> 
> >  	u32 cache_level;
> >  	int len, found = 0;
> >  	int i;
> > +	u32 cpuid = get_hard_smp_processor_id(vcpu);
> 
> s/cpuid/phys_cpu/ or similar
> 
> -Scott
> 



More information about the Linuxppc-dev mailing list