[PATCH 3/3] powerpc/kvm: remove redundant assignment

Alexander Graf agraf at suse.de
Thu Nov 7 19:14:46 EST 2013



Am 07.11.2013 um 08:55 schrieb Benjamin Herrenschmidt <benh at kernel.crashing.org>:

> On Thu, 2013-11-07 at 08:52 +0100, Alexander Graf wrote:
>> Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt <benh at kernel.crashing.org>:
>> 
>>> On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote:
>>>> On 05.11.2013, at 08:42, Liu Ping Fan <kernelfans at gmail.com> wrote:
>>>> 
>>>>> Signed-off-by: Liu Ping Fan <pingfank at linux.vnet.ibm.com>
>>>> 
>>>> Patch description missing.
>>> 
>>> Do you really need a description for trivial one-lines whose subject
>>> is a perfectly complete description already ?
>> 
>> Would I ask for it otherwise? It's also not 100% obvious that the assignment is redundant.
> 
> And ? An explanation isn't going to be clearer than the code in that
> case ...

It's pretty non-obvious when you do a git show on that patch in 1 year from now, as the redundancy is out of scope of what the diff shows.


Alex



More information about the Linuxppc-dev mailing list