net/eth/ibmveth: Fixup retrieval of MAC address

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat May 4 07:17:32 EST 2013


On Fri, 2013-05-03 at 17:30 +0100, Ben Hutchings wrote:
> > +	/* Workaround for old/broken pHyp */
> > +	if (mac_len == 8)
> > +		mac_addr_p += 2;
> > +	if (mac_len != 6) {
> 
> Missing 'else' before the second if?

Absolutely... oops :-) I couldn't find a version of pHyp with the wrong
property to test with. I suppose I could hack it up in OFW before boot.

I'll fix that and respin, sorry about that.

Cheers,
Ben.

> > +		dev_err(&dev->dev, "VETH_MAC_ADDR attribute wrong len %d\n",
> > +			mac_len);
> > +		return -EINVAL;
> > +	}
> [...]
> 




More information about the Linuxppc-dev mailing list