[PATCH v2 net-next] af_unix: fix a fatal race with bit fields

Eric Dumazet eric.dumazet at gmail.com
Thu May 2 02:00:59 EST 2013


On Wed, 2013-05-01 at 16:53 +0100, David Laight wrote:
> Why not just change gc_candidate and gc_maybe_cycle to
> unsigned char?
> It might reduce the number of pad bytes somewhat.

You didn't quite follow the discussion.

I used bytes on V1, and we are not 100% sure its safe on all arches.

unsigned long is guaranteed to be safe. We absolutely rely on this.

Better use more bytes on a socket (with no impact on real memory use),
than spending hours to debug some strange issues.





More information about the Linuxppc-dev mailing list