ppc/sata-fsl: orphan config value: CONFIG_MPC8315_DS

Scott Wood scottwood at freescale.com
Wed May 1 10:42:38 EST 2013


On 04/30/2013 07:34:39 PM, Anthony Foiani wrote:
> Scott --
> 
> Thanks for the quick reply / review!
> 
> On 04/30/2013 12:15 PM, Scott Wood wrote:
>> [The devtree approach] might be OK for a new board, but adding it  
>> now means that people using existing device trees won't get the  
>> workaround.  It might be better to just put the knowledge in  
>> platform code.
> 
> That would be fantastic, if I knew what to test.
> 
> If you look at the thread from last year, it seems that even there in  
> Freescale, nobody knows exactly what triggers this.
> 
> There was the "orphan" config value, and I simply turned that into a  
> devtree switch.
> 
> If you can find an answer inside Freescale, I can try to respin the  
> patch to accommodate that knowledge.  But until then, this is the  
> best I can do.
> 
> (And it's not a new board -- it's based on the 8315ERDB, and the  
> orphaned symbol is apparently related to another 8315 board that  
> never got released?)

I just meant that, for whatever boards you would have put this in the  
device tree, put it in platform code instead (if the platform file  
supports more than one board type, then check the compatible at the top  
of the device tree).  Or do you mean that you would not set this on any  
board's device tree by default, and instead have users set it if they  
encounter problems?  Is this a custom board you're seeing it on?

>> and submit the patch inline rather than as an attachment (e.g. use  
>> git send-email).
> 
> Will see if I can do so.  I don't actually have any sort of MTA set  
> up on this machine, hence these Thunderbirded messages.

git send-email can connect directly to an SMTP server.

-Scott


More information about the Linuxppc-dev mailing list