[PATCH 2/3] powerpc/mpic: add global timer support

Scott Wood scottwood at freescale.com
Sat Mar 23 09:29:55 EST 2013


On 03/22/2013 01:14:51 AM, Wang Dongsheng-B40534 wrote:
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, March 21, 2013 7:00 AM
> > To: Wang Dongsheng-B40534
> > Cc: Wood Scott-B07421; Gala Kumar-B11780;  
> linuxppc-dev at lists.ozlabs.org;
> > Li Yang-R58472
> > Subject: Re: [PATCH 2/3] powerpc/mpic: add global timer support
> >
> > BTW, the input clock frequency has been similarly scaled, yet you  
> don't
> > try to scrounge up that information to get further precision...
> >
> Let's go back patch, do you think the code is repeated?
> I will remove "if (!(priv->flags & FSL_GLOBAL_TIMER))" branch, there  
> will be no redundant code.

I'd rather that branch be kept and the more complicated branch deleted,  
and priv->timerfreq frequency be adjusted on initialization to account  
for the scaler.

-Scott


More information about the Linuxppc-dev mailing list