[PATCH] KVM: PPC: e500: Add separate functions for vcpu's MMU configuration

[Alexander Graf]

On 21.03.2013, at 12:19, Caraman Mihai Claudiu-B02008 wrote:

>> -----Original Message-----
>> From: kvm-ppc-owner at vger.kernel.org [mailto:kvm-ppc-
>> owner at vger.kernel.org] On Behalf Of Alexander Graf
>> Sent: Thursday, March 21, 2013 12:07 PM
>> To: Caraman Mihai Claudiu-B02008
>> Cc: kvm-ppc at vger.kernel.org; kvm at vger.kernel.org; linuxppc-
>> dev at lists.ozlabs.org
>> Subject: Re: [PATCH] KVM: PPC: e500: Add separate functions for vcpu's
>> MMU configuration
>> 
>> 
>> On 19.03.2013, at 18:16, Mihai Caraman wrote:
>> 
>>> Move vcpu's MMU default configuration and geometry update into their
>> own
>>> functions.
>> 
>> Mind to explain why?
> 
> You requested a separate function for clearing TLBnCFG_IND bit (E.PT removal)
> to self-document the code. The existing logic (that TLBnCFG_IND relies on)
> was buried in a chunk of code and I thought this will add more clarity.
> If you don't agree I would document the code at least.

I guess I'll have to see the full picture then. Please just include this patch in the series when you change the IND bit and make the patch description a bit more obvious: Just indicate that you need this a cleanup to make the IND patch more readable.


Alex