[PATCH] powerpc/uprobes: teach uprobes to ignore gdb breakpoints

Oleg Nesterov oleg at redhat.com
Wed Mar 20 23:43:01 EST 2013

On 03/20, Oleg Nesterov wrote:
> But we did not install UPROBE_SWBP_INSN. Is it fine? I hope yes, just to
> verify. If not, we need 2 definitions. is_uprobe_insn() should still check
> insns == UPROBE_SWBP_INSN, and is_swbp_insn() should check is_trap().
> And I am just curious, could you explain how X and UPROBE_SWBP_INSN
> differ?

IOW, if I wasn't clear... Lets forget about gdb/etc for the moment.
Suppose we apply the patch below. Will uprobes on powerpc work?

If yes, then your patch should be fine. If not, we probably need more

And, forgot to mention. If you change is_swbp_insn(), you can remove
is_trap() from arch_uprobe_analyze_insn().


--- x/arch/powerpc/include/asm/uprobes.h
+++ x/arch/powerpc/include/asm/uprobes.h
@@ -31,7 +31,7 @@ typedef ppc_opcode_t uprobe_opcode_t;
 /* The following alias is needed for reference from arch-agnostic code */
 #define UPROBE_SWBP_INSN_SIZE	4 /* swbp insn size in bytes */
 struct arch_uprobe {

More information about the Linuxppc-dev mailing list