[PATCH] powerpc: add Book E support to 64-bit hibernation

Johannes Berg johannes at sipsolutions.net
Wed Mar 20 08:22:07 EST 2013

On Tue, 2013-03-19 at 16:10 -0500, Scott Wood wrote:

> > I was going to say I have no idea, but looking at it again ... this is
> > in the *resume* code, not the suspend code as I'd assumed, and on  
> > resume
> > I guess I felt it was safer to not assume it didn't change, since it
> > could be a slightly different kernel that loaded and restored the
> > hibernation image?
> Wouldn't that be doomed for other reasons?

Most likely, yeah.

> I wonder about kernel modules, though flushing 32 MiB wouldn't be  
> adequate there.

Good question, but would they be running? You have to have everything
built in that you need to load the image? Or maybe not, with the
userspace image restoration that became possible at some point...

> > It should be the same one, so I guess it should be
> > exactly the same code, but I guess I wanted to make sure there wasn't
> > anything weird there. As for why it'd be 32 MiB? No idea. Although  
> > that
> > really ought to flush all your possible caches anyway, I guess.
> It's not a displacement flush (i.e. you don't do a separate load pass  
> first) -- it just flushes lines if they happen to be present, and  
> leaves alone anything outside that range.  Given that you just finished  
> copying a bunch of data, most likely what's in the cache is the last  
> bit of data you copied.

Oops, good point.

Maybe there's a way to completely flush the (i)cache? :-)


More information about the Linuxppc-dev mailing list