[PATCH] powerpc: add Book E support to 64-bit hibernation
scottwood at freescale.com
Tue Mar 19 09:12:37 EST 2013
On 03/15/2013 10:22:06 AM, Johannes Berg wrote:
> On Thu, 2013-03-14 at 11:52 -0500, Scott Wood wrote:
> > > > +#ifdef CONFIG_PPC_BOOK3S_64
> > > > /* can't use RESTORE_SPECIAL(MSR) */
> > > > ld r0, SL_MSR(r11)
> > > > mtmsrd r0, 0
> > >
> > > Unfortunately, I forgot the reason for this comment, and didn't
> put a
> > > better one (almost 6 years ago!!)
> > If it's because book3s needs mtmsrd instead of mtmsr, that doesn't
> > apply to booke.
> Indeed, looking at the code again now that seems pretty obvious.
> Looking at the patch again, I'd be a little concerned about the lack
> cache flushing, seems a bit odd but I'm sure you know what you're
> (and I don't know book3e at all, and hardly remember book3s -- or even
> that name...) :-)
Could you elaborate on why book3s flushes the way it does? What's
special about the first 32 MiB? If it's to cover kernel code, why
would that be changing from what's already there?
More information about the Linuxppc-dev