[PATCH 5/8] powerpc/fsl-booke: Add initial silicon device tree for

[Kumar Gala]

On Mar 7, 2013, at 11:47 AM, Scott Wood wrote:

> On 03/07/2013 11:09:50 AM, Kumar Gala wrote:
>> On Mar 5, 2013, at 6:15 PM, Scott Wood wrote:
>> > On 03/05/2013 05:15:57 PM, Kumar Gala wrote:
>> >> Enable a baseline T4240 SoC to boot.  There are several things missing
>> >> from the device trees for T4240:
>> >> * Thread support on e6500
>> >
>> > Why did threads get removed from the device tree?  It's supposed to describe hardware, not what Linux currently supports.
>> will fix, was concerned if we'd be able to boot if they exited
> 
> I don't think it'd be a problem (and if it is, then fix Linux).

looks fine, so I'll add them in v2 patch.

> 
>> >> +	device_type = "pci";
>> >> +	#size-cells = <2>;
>> >> +	#address-cells = <3>;
>> >> +	bus-range = <0x0 0xff>;
>> >> +	clock-frequency = <33333333>;
>> >
>> > This clock-frequency is not correct (I doubt it's needed at all).
>> I can zero the field, but its spec'd by pci binding
> 
> If we aren't going to put a correct value in, is zero better than omitting it entirely?
> 
> There are other properties in the PCI binding that we don't have, such as slot-names.  I don't see any language in the PCI binding that says one is required but the other isn't.
> 
> And shouldn't we be using the PCI express binding (device_type = "pciex", or just get rid of it since this isn't real OF)?

I'll drop clock-frequency since we dont use it.

- k