[PATCH 5/8] powerpc/fsl-booke: Add initial silicon device tree for

[Kumar Gala]

On Mar 5, 2013, at 6:15 PM, Scott Wood wrote:

> On 03/05/2013 05:15:57 PM, Kumar Gala wrote:
>> Enable a baseline T4240 SoC to boot.  There are several things missing
>> from the device trees for T4240:
>> * Thread support on e6500
> 
> Why did threads get removed from the device tree?  It's supposed to describe hardware, not what Linux currently supports.

will fix, was concerned if we'd be able to boot if they exited

> 
>> * Proper PAMU topology information
>> * DPAA related nodes (Qman, Bman, Fman, Rman, DCE)
>> * Prefetch Manager
>> * Thermal monitor unit
>> * Interlaken
> 
> The dts should be marked preliminary somehow -- we really should get out of the habit of letting device nodes trickle in as drivers get added.

agreed but forward progress always gets in the way

> 
>> +/* controller at 0x240000 */
>> +&pci0 {
>> +	compatible = "fsl,t4240-pcie", "fsl,qoriq-pcie-v3.0";
> 
> We have a version register -- do we really need to keep sticking the version number in the compatible?  Note that we've had device trees that specified the version incorrectly in the past.
> 
>> +	device_type = "pci";
>> +	#size-cells = <2>;
>> +	#address-cells = <3>;
>> +	bus-range = <0x0 0xff>;
>> +	clock-frequency = <33333333>;
> 
> This clock-frequency is not correct (I doubt it's needed at all).

I can zero the field, but its spec'd by pci binding

> 
>> +		PowerPC,e6500 at 1 {
>> +			device_type = "cpu";
>> +			reg = <2>;
>> +			next-level-cache = <&L2_1>;
>> +		};
>> +		PowerPC,e6500 at 2 {
>> +			device_type = "cpu";
>> +			reg = <4>;
>> +			next-level-cache = <&L2_1>;
>> +		};
>> +		PowerPC,e6500 at 3 {
>> +			device_type = "cpu";
>> +			reg = <6>;
>> +			next-level-cache = <&L2_1>;
>> +		};
>> +
>> +		PowerPC,e6500 at 4 {
>> +			device_type = "cpu";
>> +			reg = <8>;
>> +			next-level-cache = <&L2_2>;
>> +		};
> 
> Inconsistent whitespace.

will kill the whitespace.

> As usual, the pre/post split is unnecessary.  Everything in it can go in post.
> 
> -Scott