[PATCH 8/8] powerpc/perf: Add power8 EBB support
Michael Ellerman
michael at ellerman.id.au
Thu Jun 27 21:52:45 EST 2013
On Wed, 2013-06-26 at 15:28 +0530, Anshuman Khandual wrote:
> > @@ -117,6 +117,7 @@
> > (EVENT_UNIT_MASK << EVENT_UNIT_SHIFT) | \
> > (EVENT_COMBINE_MASK << EVENT_COMBINE_SHIFT) | \
> > (EVENT_MARKED_MASK << EVENT_MARKED_SHIFT) | \
> > + (1ull << EVENT_CONFIG_EBB_SHIFT) | \
>
> We should define this macro like EVENT_MARKED_MASK
>
> #define EVENT_EBB_MASK 0x1
>
> Numeric value of "1ull" stands out odd in the scheme.
Yeah I guess.
Would you like it in blue? :)
cheers
More information about the Linuxppc-dev
mailing list