[PATCH 2/2] powerpc/hw_brk: Fix clearing of extraneous IRQ

Anshuman Khandual khandual at linux.vnet.ibm.com
Tue Jun 25 18:59:56 EST 2013


On 06/24/2013 11:17 AM, Michael Neuling wrote:
> In 9422de3 "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint
> registers" we changed the way we mark extraneous irqs with this:
> 
> -	info->extraneous_interrupt = !((bp->attr.bp_addr <= dar) &&
> -			(dar - bp->attr.bp_addr < bp->attr.bp_len));
> +	if (!((bp->attr.bp_addr <= dar) &&
> +	      (dar - bp->attr.bp_addr < bp->attr.bp_len)))
> +		info->type |= HW_BRK_TYPE_EXTRANEOUS_IRQ;
> 
> Unfortunately this is bogus as it never clears extraneous IRQ if it's already
> set.
> 
> This correctly clears extraneous IRQ before possibly setting it.
> 
> Signed-off-by: Michael Neuling <mikey at neuling.org>
Reviewed-by: Anshuman Khandual <khandual at linux.vnet.ibm.com>



More information about the Linuxppc-dev mailing list