[PATCH 40/45] powerpc, irq: Use GFP_ATOMIC allocations in atomic context
Benjamin Herrenschmidt
benh at kernel.crashing.org
Tue Jun 25 13:13:27 EST 2013
On Tue, 2013-06-25 at 12:58 +1000, Michael Ellerman wrote:
> On Tue, Jun 25, 2013 at 12:13:04PM +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2013-06-25 at 12:08 +1000, Michael Ellerman wrote:
> > > We're not checking for allocation failure, which we should be.
> > >
> > > But this code is only used on powermac and 85xx, so it should probably
> > > just be a TODO to fix this up to handle the failure.
> >
> > And what can we do if they fail ?
>
> Fail up the chain and not unplug the CPU presumably.
BTW. Isn't Srivatsa series removing the need to stop_machine() for
unplug ? That should mean we should be able to use GFP_KERNEL no ?
Cheers,
Ben.
More information about the Linuxppc-dev
mailing list