[PATCH 25/45] staging/octeon: Use get/put_online_cpus_atomic() to prevent CPU offline

Joe Perches joe at perches.com
Mon Jun 24 05:17:25 EST 2013


On Mon, 2013-06-24 at 00:25 +0530, Srivatsa S. Bhat wrote:
> On 06/23/2013 11:47 PM, Greg Kroah-Hartman wrote:
> > On Sun, Jun 23, 2013 at 07:13:33PM +0530, Srivatsa S. Bhat wrote:
[]
> >> diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
[]
> Honestly, I don't know. Let's CC the author of that code (David Daney).
> I wonder why get_maintainer.pl didn't generate his name for this file,
> even though the entire file is almost made up of his commits alone!

Because by default, get_maintainer looks for a matching
file entry in MAINTAINERS.  Failing that, it looks at
one year of git history.  In this case, no work has been
done on the file for quite awhile.

--git-blame can be added to the get_maintainer.pl command
line to look for % of authorship by line and commit count.

Adding --git-blame can take a long time to run, that's why
it's not on by default.  Also, very old history can give
invalid email addresses as people move around and email
addresses decay.

If you always want to find original authors, you could
use a .get_maintainer.conf file with --git-blame in it.

$ time ./scripts/get_maintainer.pl --git-blame -f drivers/staging/octeon/ethernet-tx.c
Greg Kroah-Hartman <gregkh at linuxfoundation.org> (supporter:STAGING SUBSYSTEM,commits:4/16=25%)
David Daney <ddaney at caviumnetworks.com> (authored lines:711/725=98%,commits:13/16=81%)
Ralf Baechle <ralf at linux-mips.org> (commits:11/16=69%)
Eric Dumazet <eric.dumazet at gmail.com> (commits:2/16=12%)
Andrew Morton <akpm at linux-foundation.org> (commits:1/16=6%)
devel at driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel at vger.kernel.org (open list)

real	0m16.853s
user	0m16.088s
sys	0m0.444s




More information about the Linuxppc-dev mailing list