[PATCH] powerpc/pci: check the bus address instead of resource address in pcibios_fixup_resources

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Jun 6 08:38:11 EST 2013


On Wed, 2013-06-05 at 14:10 +0100, David Laight wrote:
> > If a BAR has the value of 0, we would assume that it is unset yet and
> > then mark the resource as unset and would reassign it later.
> 
> IIRC the PCI spec allows a BAR address of zero.
> Certainly some sparc systems have assigned 0 to a BAR.
> So assuming a BAR of 0 means it is unset may not be
> true for all systems.

Yes, look at the code and the comment above :-) It tries to make a
guess... which so far has worked well for us.

Note that people assigning 0 to BARs are asking for trouble anyway.

Cheers,
Ben.




More information about the Linuxppc-dev mailing list