[RFC PATCH 3/6] KVM: PPC: Book3E: Rename IRQPRIO names to accommodate ALTIVEC

[Caraman Mihai Claudiu-B02008]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, June 05, 2013 1:28 AM
> To: Caraman Mihai Claudiu-B02008
> Cc: kvm-ppc at vger.kernel.org; kvm at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org; Caraman Mihai Claudiu-B02008
> Subject: Re: [RFC PATCH 3/6] KVM: PPC: Book3E: Rename IRQPRIO names to
> accommodate ALTIVEC
> 
> On 06/03/2013 03:54:25 PM, Mihai Caraman wrote:
> > Rename BOOKE_IRQPRIO_SPE_UNAVAIL and BOOKE_IRQPRIO_SPE_FP_DATA names
> > to accommodate ALTIVEC. Replace BOOKE_INTERRUPT_SPE_UNAVAIL and
> > BOOKE_INTERRUPT_SPE_FP_DATA with the common version.
> >
> > Signed-off-by: Mihai Caraman <mihai.caraman at freescale.com>
> > ---
> >  arch/powerpc/kvm/booke.c              |   12 ++++++------
> >  arch/powerpc/kvm/booke.h              |    4 ++--
> >  arch/powerpc/kvm/bookehv_interrupts.S |    8 ++++----
> >  arch/powerpc/kvm/e500.c               |   10 ++++++----
> >  arch/powerpc/kvm/e500_emulate.c       |    8 ++++----
> >  5 files changed, 22 insertions(+), 20 deletions(-)
> 
> Can you remove the TODO separate definitions from 1/6 now?  And/or
> combine 1/6 with this patch?

TODO separate definitions are for kernel code, they require a new patch
depending on comments. I sent 1/6 to fix the build brake generated
by this

	/* altivec */
	#define BOOKE_INTERRUPT_ALTIVEC_UNAVAIL 42
	#define BOOKE_INTERRUPT_ALTIVEC_ASSIST 43

So if we agree that 42/43 numbers are wrong then I would prefer 1/6 (or something
similar) instead of adding new kvm_handlers (which legitimates the above commit)
just to remove them later.

-Mike