[PATCH] powerpc/perf: Fix deadlock caused by calling printk() in PMU exception

Michael Ellerman michael at ellerman.id.au
Tue Jun 4 19:50:32 EST 2013


On Tue, 2013-06-04 at 14:35 +0530, Anshuman Khandual wrote:
> > +	seq_printf(p, "%*s: ", prec, "PMS");
> 
> Lets make this PMIS or PMI_S instead of PMS.

Everything else is aligned using a three character prefix, so that would
stuff the alignment up.

> 
> > +	for_each_online_cpu(j)
> > +		seq_printf(p, "%10u ", per_cpu(irq_stat, j).pmu_irqs);
> 
> This would be pmu_spurious_irqs instead of pmu_irqs.

Yep, thanks for reviewing.

I'm actually thinking I'll drop the counter, at least until we can be
sure it's not us causing the spurious interrupts.

cheers





More information about the Linuxppc-dev mailing list