[PATCH 1/3] mmc:core: parse voltage from device-tree

Scott Wood scottwood at freescale.com
Wed Jul 31 05:58:54 EST 2013


On 07/29/2013 08:34:29 PM, Zhang Haijun wrote:
> On 07/30/2013 06:07 AM, Scott Wood wrote:
>> On 07/28/2013 09:56:33 PM, Haijun Zhang wrote:
>>> Add function to support get voltage from device-tree.
>>> If there are voltage-range specified in device-tree node, this  
>>> function
>>> will parse it and return the avail voltage mask.
>>> 
>>> Signed-off-by: Haijun Zhang <haijun.zhang at freescale.com>
>>> ---
>>>  drivers/mmc/core/core.c  | 48  
>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  include/linux/mmc/core.h |  1 +
>>>  2 files changed, 49 insertions(+)
>> 
>> Move the code rather than copying it.
>> 
>> -Scott
> Hi, Scott
> 
> You mean?

The point of factoring this out is to avoid duplicating the code.  If  
you don't remove it from the place you copied it from (and have that  
code call here instead), then you're not avoiding the duplication.

-Scott


More information about the Linuxppc-dev mailing list