[PATCH] Add device file bindings for MAPLE

[Leekha Shaveta-B20052]

-----Original Message-----
From: Wood Scott-B07421 
Sent: Tuesday, July 30, 2013 5:31 AM
To: Leekha Shaveta-B20052
Cc: devicetree-discuss at lists.ozlabs.org; linuxppc-dev at lists.ozlabs.org; Leekha Shaveta-B20052
Subject: Re: [PATCH] Add device file bindings for MAPLE

On 07/27/2013 08:03:42 AM, Shaveta Leekha wrote:
> Signed-off-by: Shaveta Leekha <shaveta at freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/maple.txt      |   50  
> ++++++++++++++++++++
>  1 files changed, 50 insertions(+), 0 deletions(-)  create mode 100644 
> Documentation/devicetree/bindings/powerpc/fsl/maple.txt
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/maple.txt
> b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt
> new file mode 100644
> index 0000000..23b80a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt
> @@ -0,0 +1,50 @@
> +* Freescale MAPLE Multi Accelerator Platform Engine Baseband 3
> +  (MAPLE-B3)device nodes
> +
> +Supported chips:
> +Example: B4860
> +
> +Required properties:
> +
> +- compatible:	Should contain "fsl,maple-b3" as the value
> +		This identifies Multi Accelerator Platform Engine
> +		Baseband 3 block.
> +
> +- reg:		offset and length of the register set for the  
> device
> +
> +- interrupts
> +	Usage: required
> +	Value type: <prop_encoded-array>
> +	Definition:  Specifies the interrupts generated by this
> device.  The
> +			value of the interrupts property consists of
> one interrupt
> +			specifier. The format of the specifier is
> defined by the
> +			binding document describing the node's
> interrupt parent.

Please clean up whitespace so the text aligns.
[Leekha Shaveta-B20052] ok. Will remove whitespaces.

> +
> +		A single IRQ that handles error conditions is specified
> by
> +		this property.  (Typically shared with port-write).
> +
> +Devices that have LIODNs need to specify links to the parent PAMU
> controller
> +(the actual PAMU controller that this device is connected to) and a
> pointer to
> +the LIODN register, if applicable.
> +
> +- fsl,iommu-parent
> +		: <phandle>
> +		This property should be present
> +
> +- status = "disabled"
> +		In this example, status is set "disabled",
> +		As Maple device wouldn't be used by PPC Linux. This
> representation is required
> +		for doing the PAMU programming on the Linux side.

Is it proper for Linux to even set the LIODN on a device that is "disabled"?  Perhaps the compatible should be different, such as "fsl,maple-b3-liodn" to indicate that that is the only portion of the device that is owned by this partition.

> +Example:
> +	/* B4860 */
> +
> +	maple at 800000 {
> +		#address-cells = <0>;
> +		#size-cells = <0>;
> +		status = "disabled";
> +		compatible = "fsl,maple-b3";
> +		reg = <0x8000000 0x10000>;
> +		interrupts = <16 2 1 18>;
> +		fsl,iommu-parent = <&pamu1>;
> +	};

This error interrupt is documented as 13, not 18.  b4860 (and maybe other b4?) have an erratum that says that error interrupts are reversed, but this is generally implemented in b4si-post.dtsi, not in block-specific include files.  Will no chip without the erratum ever have maple?
[Leekha Shaveta-B20052] You are right here. Will add the interrupts in b4si or b4860si file, as other chips may have maple.
Regards,
Shaveta

-Scott