[PATCH 2/2 V2] mmc: esdhc: get voltage from dts file

[Zhang Haijun]

On 07/27/2013 03:18 AM, Anton Vorontsov wrote:
> On Thu, Jul 25, 2013 at 08:38:11AM +0800, Haijun Zhang wrote:
>> Add voltage-range support in esdhc of T4, So we can choose
>> to read voltages from dts file as one optional.
>> If we can get a valid voltage-range from device node, we use
>> this voltage as the final voltage support. Else we still read
>> from capacity or from other provider.
>>
>> Signed-off-by: Haijun Zhang <haijun.zhang at freescale.com>
>> Signed-off-by: Anton Vorontsov <cbouatmailru at gmail.com>
> Development process nitpick...
>
> The code originated from me, but I did not sign off this patch...
>
> Per Documentation/SubmittingPatches:
>
>    The Signed-off-by: tag indicates that the signer was involved in the
>    development of the patch, or that he/she was in the patch's delivery path.
>
> The order of the sign-off lines also has a meaning. Putting my sign off
> below yours means that I was not only involved in the development of the
> patch but also somehow approved the patch (but I did not :).
>
> [..]
>> +void sdhci_get_voltage(struct platform_device *pdev)
> You still duplicate the code... Per my previous email, this should
> probably go into mmc/core (with the function renamed to something more
> generic, of course.)
>
> Thanks,
>
> Anton
>
Thanks Anton.

I'll correct this and resend the patch.

-- 
Thanks & Regards

Haijun