[PATCH v2] powerpc: kernel: remove useless code which related with 'max_cpus'
Benjamin Herrenschmidt
benh at kernel.crashing.org
Thu Jul 25 17:33:12 EST 2013
On Thu, 2013-07-25 at 14:17 +0800, Chen Gang wrote:
>
> Hmm... for an extern function (espeically have been implemented in
> various modules), normally, we can assume it may fail in some cases
> (although now, we don't know what cases can cause its failure).
>
> If "we don't have a good way to handle the failure", "print the related
> warning message" is an executable choice (or "BUG_ON()", if it is critical).
>
> So, if the performance is not sensible, I still suggest to let extern
> function have return value.
This is not a module function. We are not doing a uni course on how to
write C code here. Be real.
Ben.
More information about the Linuxppc-dev
mailing list