[PATCH] powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb()

Bjorn Helgaas bhelgaas at google.com
Tue Jul 23 10:28:21 EST 2013


On Mon, Jul 22, 2013 at 12:52 AM, Chen Gang <gang.chen at asianux.com> wrote:
> pnv_pci_init_ioda2_phb() is only used during boot up, so need add
> '__init' to save the related memory, and avoid related warning:
>
>   The function .pnv_pci_init_ioda2_phb() references
>   the function __init .pnv_pci_init_ioda_phb().
>   This is often because .pnv_pci_init_ioda2_phb lacks a __init
>   annotation or the annotation of .pnv_pci_init_ioda_phb is wrong.
>
>
> Signed-off-by: Chen Gang <gang.chen at asianux.com>

Looks right to me.

> ---
>  arch/powerpc/platforms/powernv/pci-ioda.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 49b57b9..d8140b1 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1266,7 +1266,7 @@ void __init pnv_pci_init_ioda_phb(struct device_node *np,
>                 opal_pci_set_pe(phb_id, 0, 0, 7, 1, 1 , OPAL_MAP_PE);
>  }
>
> -void pnv_pci_init_ioda2_phb(struct device_node *np)
> +void __init pnv_pci_init_ioda2_phb(struct device_node *np)
>  {
>         pnv_pci_init_ioda_phb(np, 0, PNV_PHB_IODA2);
>  }
> --
> 1.7.7.6


More information about the Linuxppc-dev mailing list