[PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS board

[Zhang Haijun-B42677]

Hi, Anton

You mean get voltage support from DTS?
Or get voltage both from DTS and host capacity register?

Thanks.

Regards
Haijun.


> -----Original Message-----
> From: linux-mmc-owner at vger.kernel.org [mailto:linux-mmc-
> owner at vger.kernel.org] On Behalf Of Anton Vorontsov
> Sent: Saturday, July 13, 2013 2:35 AM
> To: Wood Scott-B07421
> Cc: Zhang Haijun-B42677; linux-mmc at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org; cjb at laptop.org; Fleming Andy-AFLEMING; Wrobel
> Heinz-R39252
> Subject: Re: [PATCH 3/4 V2] mmc: esdhc: Add quirks to support T4240QDS
> board
> 
> On Mon, Jul 08, 2013 at 12:18:39PM -0500, Scott Wood wrote:
> > On 07/08/2013 02:16:04 AM, Haijun Zhang wrote:
> > >On T4240QDS board controllers has an unusable ADMA engine, so use
> > >SDMA instead.
> > >Also 3.0v is support on T4240QDS board even if the capacity detailed
> > >only 1.8v support. Without this quirk SD card will declare voltage
> > >not support and
> > >
> > >Signed-off-by: Haijun Zhang <haijun.zhang at freescale.com>
> >
> > ...and what?
> >
> > Why is this board-specific?  Isn't the controller part of the SoC, not
> > part of the board?  If it really is board-specific, could you be more
> > detailed about why (ideally with an erratum number), and check the
> > toplevel board compatible (or get the information from platform
> > code) rather than modify the device tree?
> 
> Yup, and if anything, I would recommend to reuse voltage-ranges property,
> it is already implemented for mmc spi driver,
> 
> drivers/mmc/host/of_mmc_spi.c
> Documentation/devicetree/bindings/mmc/mmc-spi-slot.txt
> 
> Thanks,
> 
> Anton
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html