[PATCH 2/2 V4] powerpc/85xx: add the P1020RDB-PD DTS support

[Scott Wood]

On 07/09/2013 09:24:57 PM, Haijun Zhang wrote:
> +		nand at 1,0 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			compatible = "fsl,p1020-fcm-nand",
> +				     "fsl,elbc-fcm-nand";
> +			reg = <0x1 0x0 0x40000>;
> +
> +			partition at 0 {
> +				/* This location must not be altered  */
> +				/* 1MB for u-boot Bootloader Image */
> +				reg = <0x0 0x00100000>;
> +				label = "NAND U-Boot Image";
> +				read-only;
> +			};
> +
> +			partition at 100000 {
> +				/* 1MB for DTB Image */
> +				reg = <0x00100000 0x00100000>;
> +				label = "NAND DTB Image";
> +			};
> +
> +			partition at 200000 {
> +				/* 4MB for Linux Kernel Image */
> +				reg = <0x00200000 0x00400000>;
> +				label = "NAND Linux Kernel Image";
> +			};
> +
> +			partition at 600000 {
> +				/* 96MB for File System Image */
> +				reg = <0x00600000 0x06000000>;
> +				label = "NAND FILE System Image";
> +			};

This accounts for 102 MiB of the flash.  The rest is just unused?  Why  
not increase the filesystem partition?

Also, why capitalize "FILE"?

> +		spi at 7000 {
> +			flash at 0 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible = "spansion,s25sl12801";
> +				reg = <0>;
> +				/* input clock */
> +				spi-max-frequency = <40000000>;
> +
> +				partition at 0 {
> +					/* 512KB for u-boot Bootloader  
> Image */
> +					reg = <0x0 0x00080000>;
> +					label = "SPI U-Boot Image";
> +					read-only;
> +				};
> +
> +				partition at 80000 {
> +					/* 512KB for DTB Image*/
> +					reg = <0x00080000 0x00080000>;
> +					label = "SPI DTB Image";
> +				};
> +
> +				partition at 100000 {
> +					/* 4MB for Linux Kernel Image */
> +					reg = <0x00100000 0x00400000>;
> +					label = "SPI Linux Kernel  
> Image";
> +				};
> +
> +				partition at 500000 {
> +					/* 7MB for FS System Image */
> +					reg = <0x00500000 0x00700000>;
> +					label = "SPI File System Image";
> +				};
> +			};

Likewise.

-Scott