RE: 答复: [PATCH] Powerpc/t4240: change the compatible flags for t4240qds board

[Zhang Haijun-B42677]

Thanks.

Regards
Haijun.


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, July 11, 2013 4:30 AM
> To: Zhang Haijun-B42677
> Cc: Wood Scott-B07421; linux-mmc at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org; cbouatmailru at gmail.com; cjb at laptop.org; Fleming
> Andy-AFLEMING; Wrobel Heinz-R39252
> Subject: Re: 答复: [PATCH] Powerpc/t4240: change the compatible flags for
> t4240qds board
> 
> On 07/09/2013 10:41:22 PM, Zhang Haijun-B42677 wrote:
> > > No.  It's still supposed to be describing the sdhc block itself,
> > not the
> > > board -- and any workarounds that key off of this will still fail
> > to work
> > > with existing device trees.
> > [Haijun Wrote:] So, leave dts unchanged and to check compitable for
> > board in sdhci-pltfm.c
> > e.g.:
> > 	unsigned long root = of_get_flat_dt_root();
> >
> > 	if (of_flat_dt_is_compatible(root, "fsl,T4240QDS"))
> > 		host->quirks |= XXX;
> 
> Why are you looking at the flat tree at this point?  Use the normal OF
> accessors.  The flat stuff is only for early boot.
> 
> Also make sure that you only do this for quirks that are actually board-
> specific.  In your last patch you had two quirks keyed off of the board,
> one of which is keyed off of the SoC for other chips.
> 
[Haijun Wrote:] Actually there are only one board with T4240 Soc. I'll try to verify these two defect with hardware team. Hope can some help.
Once clear I'll resend the patch. Thanks for your kindly review.
> -SCott