[PATCH 1/2] powerpc/booke64: Use common defines for AltiVec interrupts numbers

Caraman Mihai Claudiu-B02008 B02008 at freescale.com
Wed Jul 3 22:25:22 EST 2013


> So we can remove this hack in kvm_asm.h:

Not yet, this comment was added in the context of AltiVec RFC patches
which intended to remove a similar dependency.

> 
> /*
>   * TODO: Unify 32-bit and 64-bit kernel exception handlers to use same
> defines
>   */
> #define BOOKE_INTERRUPT_SPE_UNAVAIL BOOKE_INTERRUPT_SPE_ALTIVEC_UNAVAIL
> #define BOOKE_INTERRUPT_SPE_FP_DATA
> BOOKE_INTERRUPT_SPE_FP_DATA_ALTIVEC_ASSIST
> #define BOOKE_INTERRUPT_ALTIVEC_UNAVAIL
> BOOKE_INTERRUPT_SPE_ALTIVEC_UNAVAIL
> #define BOOKE_INTERRUPT_ALTIVEC_ASSIST \
> 
> BOOKE_INTERRUPT_SPE_FP_DATA_ALTIVEC_ASSIST
> 
> It was added as a compilation fix, and it was less intrusive to
> temporarily fix it this way.
> 
> I am curious why the above code wasn't removed at the end of this
> patchset. :-)

Before removing it we also need to apply at least the first patch from
the Altivec set that I will send today.

-Mike



More information about the Linuxppc-dev mailing list