[PATCH 1/2] powerpc: enable the relocatable support for the fsl booke 32bit kernel

[Scott Wood]

On 06/30/2013 02:33:10 AM, Kevin Hao wrote:
> On Thu, Jun 27, 2013 at 08:47:27PM -0500, Scott Wood wrote:
> > On 06/27/2013 08:36:37 PM, Kevin Hao wrote:
> > >On Thu, Jun 27, 2013 at 02:58:34PM -0500, Scott Wood wrote:
> > >> On 06/26/2013 09:00:33 PM, Kevin Hao wrote:
> > >> >This is based on the codes in the head_44x.S. Since we always
> > >align to
> > >> >256M before mapping the PAGE_OFFSET for a relocatable kernel,
> > >we also
> > >> >change the init tlb map to 256M size.
> > >>
> > >> Why 256M?
> > >
> > >For two reasons:
> > >  1. This is the size which both e500v1 and e500v2 support.
> > >  2. Since we always use the PAGE_OFFSET as 0xc0000000, the 256M is
> > >     max alignment value we can use for this virtual address.
> >
> > Is there any reason why 64M won't continue to work here?
> 
> Yes. In general we would map the 0 ~ 256M memory region in the first
> tlb1 entry. If we align to 64M, the relocatable kernel would not work
> if loaded above 64M memory. For example, if we load a relocatable  
> kernel
> at 64M memory, we will relocate it as:
> 	__pa(PAGE_OFFSET) = 0x4000000
> 
> But in map_mem_in_cams function, it will create a memory map as:
> 	__pa(PAGE_OFFSET) = 0x0
> 
> The kernel will definitely not work in this case.

That's a problem with map_mem_in_cams(), as discussed in the thread on  
other patch.  Perhaps fully solving those problems is not worthwhile at  
this time, but we should at least be able to determine the TLB size  
automatically based on the alignment of the address you're trying to  
map.  64M would be used unless (address & (256M - 1)) >= 64M.  I hope  
we can continue to assume the kernel won't cross a 64M boundary.

> > >> This tightens the alignment requirement for dynamic memstart.
> > >
> > >Yes. But since RELOCATABLE is a superset of DYNAMIC_MEMSTART, we
> > >can always
> > >use RELOCATABLE instead of DYNAMIC_MEMSTART for fsl booke board in
> > >any cases.
> >
> > The extra flexibility of RELOCATABLE may help some use cases, but
> > you'd still require the entire 256M naturally aligned region
> > containing the kernel to be present and owned by this instance of
> > Linux.
> >
> > >So DYNAMIC_MEMSTART will seem not so useful after we enable this
> > >feature.
> >
> > Then why doesn't this patch remove it?
> 
> According to the Kconfig it is still used by 44x.

RELOCATABLE appears to be supported on 44x, and is what CRASH_DUMP uses  
on 44x.

> And maybe someone still want to use this relocation method.

Then you don't get to dismiss claims that you're changing  
DYNAMIC_MEMSTART alignment requirements by saying that RELOCATABLE is a  
strict superset. :-)  Given the requirement that the kernel be in the  
first TLB entry, though, using RELOCATABLE rather than DYNAMIC_MEMSTART  
doesn't fix the alignment problem.

I don't think it makes sense to keep both mechanisms around unless  
there's some obvious reason to prefer DYNAMIC_MEMSTART.

> > >>  And
> > >> what about boards with less than 256 MiB of RAM?
> > >
> > >It should be fine. We just create the map in the tlb. The MM still  
> use
> > >the real size of memory.
> >
> > No, you must not map anything that is not present with a mapping
> > that is executable and/or not guarded, or you could get speculative
> > accesses to who-knows-what.
> 
> Yes, there may be speculative access in this case.
> 
> >  Even if RAM is present there but owned
> > by some other entity, you could be creating illegal aliases if that
> > other entity mapped it cache-inhibited or similar.
> 
> Fair enough. So it seems error prone if we map this 256M memory region
> blindly. But if we don't do this, it seems that we have to do twice  
> relocation.
> The first time we just align to a predefined value (64M for example),  
> and
> then parse the device tree and get the real memstart_addr. After that  
> we
> should relocate the kernel to the real start address. It seems a  
> little
> complicated. Do you have any better ideas?

This seems like the proper way to address it, assuming we're unwilling  
to map the kernel image somewhere other than the normal lowmem mapping  
(and I think we're unwilling, given how tight the address space is on  
32-bit, and the intrusiveness of the change).  The dynamic  
determination of 64M versus 256M could be an acceptable alternative  
though, if we're OK with not supporting arbitrary relocatable  
scenarios, but just those that are either needed by kdump, or supported  
by current kernels (with DYNAMIC_MEMSTART, or just starting at zero  
with less than 256M of RAM).  If we go that route, the limitations  
should be documented.

-Scott