[PATCH 1/5] net: mvmdio: unmap base register address at driver removal
thomas.petazzoni at free-electrons.com
Wed Jan 30 02:32:42 EST 2013
Dear Florian Fainelli,
On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote:
> Fix the driver remove callback to unmap the base register address and
> not leak this mapping after the driver has been removed.
> Signed-off-by: Florian Fainelli <florian at openwrt.org>
What about using devm_request_and_ioremap() instead, in order to get
automatic unmap on error and in the ->remove() path?
But maybe it won't work because this memory range is claimed both by
the MDIO driver and the Ethernet driver itself. In that case, you could
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
More information about the Linuxppc-dev