[PATCH v6 04/15] memory-hotplug: remove /sys/firmware/memmap/X sysfs
Tang Chen
tangchen at cn.fujitsu.com
Thu Jan 10 17:07:37 EST 2013
Hi Andrew,
On 01/10/2013 06:49 AM, Andrew Morton wrote:
> On Wed, 9 Jan 2013 17:32:28 +0800
> Tang Chen<tangchen at cn.fujitsu.com> wrote:
>
>> When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type}
>> sysfs files are created. But there is no code to remove these files. The patch
>> implements the function to remove them.
>>
>> Note: The code does not free firmware_map_entry which is allocated by bootmem.
>> So the patch makes memory leak. But I think the memory leak size is
>> very samll. And it does not affect the system.
>
> Well that's bad. Can we remember the address of that memory and then
> reuse the storage if/when the memory is re-added? That at least puts an upper
> bound on the leak.
I think we can do this. I'll post a new patch to do so.
Thanks. :)
>
>
More information about the Linuxppc-dev
mailing list