[RFC][PATCH] powerpc: add Book E support to 64-bit hibernation

[Wang Dongsheng-B40534]

> -----Original Message-----
> From: Johannes Berg [mailto:johannes at sipsolutions.net]
> Sent: Friday, February 22, 2013 5:09 PM
> To: Wang Dongsheng-B40534
> Cc: benh at kernel.crashing.org; linuxppc-dev at lists.ozlabs.org; Wood Scott-
> B07421; Li Yang-R58472; Zhao Chenhui-B35336
> Subject: Re: [RFC][PATCH] powerpc: add Book E support to 64-bit
> hibernation
> 
> Hi,
> 
> > > Subject: [RFC][PATCH] powerpc: add Book E support to 64-bit
> > > hibernation
> 
> > Any thoughts about this patch?
> 
> Heh, honestly, no. I know nothing about Book E, and it's too long ago
> that I wrote (some of) the 64-bit hibernation code.
> 
Thanks for your feedback.

Could you give me some advice about cache flush. It confused me that why
only 1 MiB is flushed from KERNEL_START on Powermac G5.

On FSL Book E(e500 family), Even if I don't flash cache, the work is
also normal(Dcaches are kept coherent by hardware, and icaches are kept
coherent by software). But I still worry about caches. Is there a need
to flush L2 cache if I have already flushed L1 cache? 
Or on Powermac G5, flush caches is a general way?

Powermac G5 Codes:
        /* flush caches */
        lis     r3, 0x10
        mtctr   r3
        li      r3, 0
        ori     r3, r3, CONFIG_KERNEL_START>>48
        li      r0, 48
        sld     r3, r3, r0
        li      r0, 0
1:
        dcbf    r0,r3
        addi    r3,r3,0x20
        bdnz    1b

        sync

        tlbia

> johannes
>