[PATCH v2 1/1] powerpc/85xx: Board support for ppa8548

[Stef van Os]

On 02/12/2013 09:09 PM, Kumar Gala wrote:
>
> On Feb 4, 2013, at 9:30 AM, Timur Tabi wrote:
>
>> On 02/03/2013 01:39 PM, Stef van Os wrote:
>>
>>> +	pci0: pci at fe0008000 {
>>> +		status = "disabled";
>>> +	};
>>> +
>>> +	pci1: pci at fe0009000 {
>>> +		status = "disabled";
>>> +	};
>>> +
>>> +	pci2: pcie at fe000a000 {
>>> +		status = "disabled";
>>> +	};
>>
>> I was hoping you'd follow my example and include a comment indicating why the PCI devices are all disabled.
>>
>>> +static void ppa8548_show_cpuinfo(struct seq_file *m)
>>> +{
>>> +	uint svid, phid1;
>>
>> Please don't used unsized integers for hardware registers.
>>
>> 	uint32_t svid, phid1;
>
>
> Stef,
>
> If you'd like this included for 3.9, please make the minor updates.
>
> thanks
>
> - k

Patches are on their way. Thanks!

Stef.