[PATCH v3 0/7] net: use platform_{get,set}_drvdata()

Libo Chen clbchenlibo.chen at huawei.com
Fri Aug 16 12:15:40 EST 2013


On 2013/8/16 6:39, David Miller wrote:
> From: David Miller <davem at davemloft.net>
> Date: Thu, 15 Aug 2013 15:23:59 -0700 (PDT)
> 
>> From: Libo Chen <clbchenlibo.chen at huawei.com>
>> Date: Thu, 15 Aug 2013 21:01:17 +0800
>>
>>> Use the wrapper functions for getting and setting the driver data using
>>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>>> so we can directly pass a struct platform_device.
>>>
>>> changelog v3:
>>> 	remove modify about dev_set_drvdata()
>>> changelog v2:
>>> 	this version add modify record about dev_set_drvdata().
>>
>> Series applied.
> 
> Actually, I had to revert, these patches break the build.
> 
> drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_probe’:
> drivers/net/ethernet/sun/sunhme.c:3114:2: error: implicit declaration of function ‘platform_set_drvdata’ [-Werror=implicit-function-declaration]
> drivers/net/ethernet/sun/sunhme.c: In function ‘happy_meal_pci_remove’:
> drivers/net/ethernet/sun/sunhme.c:3162:9: error: implicit declaration of function ‘platform_get_drvdata’ [-Werror=implicit-function-declaration]
> drivers/net/ethernet/sun/sunhme.c:3162:26: warning: initialization makes pointer from integer without a cast [enabled by default]
> 


oh, it is my fault, I will update!



More information about the Linuxppc-dev mailing list