[PATCH v4 09/31] powerpc/fsl-pci: improve clock API use

Gerhard Sittig gsi at denx.de
Mon Aug 12 17:57:06 EST 2013


On Thu, Aug 08, 2013 at 22:12 +0200, Anatolij Gustschin wrote:
> 
> On Tue,  6 Aug 2013 22:43:49 +0200
> Gerhard Sittig <gsi at denx.de> wrote:
> ...
> > diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
> > index 46ac1dd..549ff08 100644
> > --- a/arch/powerpc/sysdev/fsl_pci.c
> > +++ b/arch/powerpc/sysdev/fsl_pci.c
> ...
> > +	clk = devm_clk_get(&pdev->dev, "per");
> > +	if (!IS_ERR(clk)) {
> > +		ret = clk_prepare_enable(clk);
> > +		if (ret) {
> > +			dev_err(dev, "Could not enable peripheral clock\n");
> 
> above line will break building. s/dev,/&pdev->dev,/

Thank you for testing and for the feedback.

I've queued this fix for v5.  The bug could hide because the file
gets compiled on MPC512x, but this specific routine sits behind
even more compile time switches (85xx and 86xx related).


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the Linuxppc-dev mailing list