[PATCH 00/11] Add compression support to pstore

Tony Luck tony.luck at gmail.com
Wed Aug 7 13:25:55 EST 2013


On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah
<aruna at linux.vnet.ibm.com> wrote:
> The patch looks right. I will clean it up. Does the issue still persist
> after this?

Things seem to be working - but testing has hardly been extensive (just
a couple of forced panics).

I do have one other question. In this code:

>>                  if (compressed && (type == PSTORE_TYPE_DMESG)) {
>>                          big_buf_sz = (psinfo->bufsize * 100) / 45;

Where does the magic multiply by 1.45 come from?  Is that always enough
for the decompression of "dmesg" type data to succeed?

-Tony


More information about the Linuxppc-dev mailing list