[PATCH] powerpc/spufs: Initialise inode->i_ino in spufs_new_inode()
Benjamin Herrenschmidt
benh at kernel.crashing.org
Wed Apr 24 11:16:54 EST 2013
On Wed, 2013-04-24 at 11:13 +1000, Michael Ellerman wrote:
> In commit 85fe402 (fs: do not assign default i_ino in new_inode), the
> initialisation of i_ino was removed from new_inode() and pushed down
> into the callers. However spufs_new_inode() was not updated.
>
> This exhibits as no files appearing in /spu, because all our dirents
> have a zero inode, which readdir() seems to dislike.
>
> Cc: stable at vger.kernel.org
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
Christoph/Al, can I have an Ack for this before I shoot it to Linus ?
Thanks !
Cheers,
Ben.
---
> arch/powerpc/platforms/cell/spufs/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/cell/spufs/inode.c
b/arch/powerpc/platforms/cell/spufs/inode.c
> index 3f3bb4c..35f77a4 100644
> --- a/arch/powerpc/platforms/cell/spufs/inode.c
> +++ b/arch/powerpc/platforms/cell/spufs/inode.c
> @@ -99,6 +99,7 @@ spufs_new_inode(struct super_block *sb, umode_t
mode)
> if (!inode)
> goto out;
>
> + inode->i_ino = get_next_ino();
> inode->i_mode = mode;
> inode->i_uid = current_fsuid();
> inode->i_gid = current_fsgid();
>
More information about the Linuxppc-dev
mailing list