[PATCH V2] powerpc/MPIC: Add get_version API both for internal and external use

[Jia Hongtao-B38951]

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, March 30, 2013 5:55 AM
> To: Wood Scott-B07421
> Cc: Jia Hongtao-B38951; linuxppc-dev at lists.ozlabs.org;
> galak at kernel.crashing.org; Wood Scott-B07421; Li Yang-R58472; Jia
> Hongtao-B38951
> Subject: Re: [PATCH V2] powerpc/MPIC: Add get_version API both for
> internal and external use
> 
> On 03/29/2013 04:51:59 PM, Scott Wood wrote:
> > On 03/26/2013 12:28:10 AM, Jia Hongtao wrote:
> >> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> >> index d30e6a6..c893a4b 100644
> >> --- a/arch/powerpc/sysdev/mpic.c
> >> +++ b/arch/powerpc/sysdev/mpic.c
> >> @@ -1165,10 +1165,27 @@ static struct irq_domain_ops mpic_host_ops =
> >> {
> >>  	.xlate = mpic_host_xlate,
> >>  };
> >>
> >> +static u32 mpic_get_version(struct mpic *mpic) {
> >> +	u32 brr1;
> >> +
> >> +	brr1 = _mpic_read(mpic->reg_type, &mpic->thiscpuregs,
> >> +			MPIC_FSL_BRR1);
> >> +
> >> +	return brr1 & MPIC_FSL_BRR1_VER;
> >> +}
> >> +
> >>  /*
> >>   * Exported functions
> >>   */
> >>
> >> +u32 mpic_primary_get_version(void)
> >> +{
> >> +	struct mpic *mpic = mpic_primary;
> >> +
> >> +	return mpic_get_version(mpic);
> >> +}
> >
> > So this just crashes if there is no mpic_primary or it's a non-FSL
> > MPIC?
> 
> ...and since it's specifically checking for the FSL version, "fsl"
> should be in the name.
> 
> -Scott

Right, I will update it with next version.

- Hongtao.