[linuxppc-release] [PATCH] powerpc/fsl-pci: Add PCI controller ATMU PM support

[Jia Hongtao-B38951]

> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Thursday, November 01, 2012 9:26 PM
> To: Jia Hongtao-B38951
> Cc: linuxppc-dev at lists.ozlabs.org; galak at kernel.crashing.org; Wood Scott-
> B07421; Li Yang-R58472
> Subject: Re: [linuxppc-release] [PATCH] powerpc/fsl-pci: Add PCI
> controller ATMU PM support
> 
> Jia Hongtao wrote:
> 
> > +#ifdef CONFIG_SUSPEND
> > +static int fsl_pci_resume(struct platform_device *pdev)
> > +{
> > +	struct pci_controller *hose;
> > +	struct resource pci_rsrc;
> > +
> > +	hose = pci_find_hose_for_OF_device(pdev->dev.of_node);
> > +	of_address_to_resource(pdev->dev.of_node, 0, &pci_rsrc);
> > +	setup_pci_atmu(hose, &pci_rsrc);
> > +
> > +	return 0;
> > +}
> 
> Some of these functions can fail, so they should return an error code if
> they do.

I checked the of_address_to_resource function now.
Is that necessary to check other two fuctions?

> 
> > +#endif
> > +
> >  static struct platform_driver fsl_pci_driver = {
> >  	.driver = {
> >  		.name = "fsl-pci",
> >  		.of_match_table = pci_ids,
> >  	},
> >  	.probe = fsl_pci_probe,
> > +#ifdef CONFIG_SUSPEND
> > +	.resume	= fsl_pci_resume,
> > +#endif
> 
> Do this instead:
> 
> #ifdef CONFIG_SUSPEND
> static int fsl_pci_resume(struct platform_device *pdev)
> ...
> #else
> #define fsl_pci_resume NULL
> #endif

Ok, I will update this.

-Hongtao.