[PATCH 1/2] powerpc/watchdog: move booke watchdog param related code to prom.c

Xie Shaohui-B21989 B21989 at freescale.com
Wed May 9 13:20:04 EST 2012


>> -----Original Message-----
>> From:
>> linuxppc-dev-bounces+bharat.bhushan=freescale.com at lists.ozlabs.org
>> [mailto:linuxppc-dev-bounces+bharat.bhushan=freescale.com at lists.ozlabs
>> .org] On Behalf Of Shaohui Xie
>> Sent: Tuesday, May 08, 2012 11:37 AM
>> To: linux-watchdog at vger.kernel.org; linuxppc-dev at lists.ozlabs.org
>> Cc: Xie Shaohui-B21989
>> Subject: [PATCH 1/2] powerpc/watchdog: move booke watchdog param
>> related code to prom.c
>>
>> Currently, BOOKE watchdog code for checking "wdt" and "wdt_period" is
>> in setup_32.c, it cannot be used in 64-bit, so move it to a common
>> place prom.c, which will be shared by 32-bit and 64-bit.
>>
>> Also, replace the simple_strtoul with kstrtol.
>>
>> Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
>> ---
>>  arch/powerpc/kernel/prom.c     |   27 +++++++++++++++++++++++++++
>>  arch/powerpc/kernel/setup_32.c |   24 ------------------------
>>  2 files changed, 27 insertions(+), 24 deletions(-)
>
>Is not setup-common.c is better place to move this?

Move out from setup_32.c does not mean it have to go into setup-common.c, I need better reason to do this.


Best Regards, 
Shaohui Xie



More information about the Linuxppc-dev mailing list