[PATCH 00/17] mark const init data with __initconst instead of __initdata

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Mar 30 20:59:00 EST 2012

On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote:
> Hello,
> this series fixes a common error to use __initdata to mark const
> variables. Most of the time this works well enough to go unnoticed
> (though I wonder why the linker doesn't warn about that).
> Just try adding something like
> 	int something __initdata;
> to one of the patched files and compile to see the error.
> While touching these annotations I also corrected the position where it
> was wrong to go between the variable name and the =.
> Note this series is not compile tested.
After a question by Shawn Guo I noticed that my command to do the changes
was to lax and changed things that must not be changed (at least not
with further care). Affected are lines like:

	static const char *at91_dt_board_compat[] __initconst = {

While at91_dt_board_compat[0] is const, at91_dt_board_compat is not.

I will send a fixed series later today.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

More information about the Linuxppc-dev mailing list