[patch 2/2] arch/powerpc/platforms/pseries/eeh_event.c: slightly fix set_current_state() wart

akpm at linux-foundation.org akpm at linux-foundation.org
Thu Mar 29 09:20:58 EST 2012

From: Andrew Morton <akpm at linux-foundation.org>
Subject: arch/powerpc/platforms/pseries/eeh_event.c: slightly fix set_current_state() wart

That set_current_state() won't work very well: the subsequent mutex_lock()
might flip the task back into TASK_RUNNING.

Attempt to put it somewhere where it might have been meant to be, and
attempt to describe why it might have been added.

Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Cc: Paul Mackerras <paulus at samba.org>
Cc: Grant Likely <grant.likely at secretlab.ca>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>

 arch/powerpc/platforms/pseries/eeh_event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/powerpc/platforms/pseries/eeh_event.c~arch-powerpc-platforms-pseries-eeh_eventc-slightly-fix-set_current_state-wart arch/powerpc/platforms/pseries/eeh_event.c
--- a/arch/powerpc/platforms/pseries/eeh_event.c~arch-powerpc-platforms-pseries-eeh_eventc-slightly-fix-set_current_state-wart
+++ a/arch/powerpc/platforms/pseries/eeh_event.c
@@ -60,7 +60,6 @@ static int eeh_event_handler(void * dumm
 	struct eeh_dev *edev;
 	set_task_comm(current, "eehd");
-	set_current_state(TASK_INTERRUPTIBLE);
 	spin_lock_irqsave(&eeh_eventlist_lock, flags);
 	event = NULL;
@@ -83,6 +82,7 @@ static int eeh_event_handler(void * dumm
 	printk(KERN_INFO "EEH: Detected PCI bus error on device %s\n",
+	set_current_state(TASK_INTERRUPTIBLE);	/* Don't add to load average */
 	edev = handle_eeh_events(event);
 	eeh_clear_slot(eeh_dev_to_of_node(edev), EEH_MODE_RECOVERING);

More information about the Linuxppc-dev mailing list