[PATCH 2/4] powerpc/mpic: Use the MPIC_LARGE_VECTORS flag for FSL MPIC.

Kumar Gala galak at kernel.crashing.org
Wed Mar 28 00:30:50 EST 2012


On Mar 27, 2012, at 7:15 AM, Varun Sethi wrote:

> FSL MPIC supports 16 bit vectors so our vector number space isn't
> restricted to 256 vectors. We should use the MPIC_LARG_VECTORS flag
> while intializing the MPIC. This also prevents us from eating in to 
> hardware vector number space (MSIs) while setting up internal sources.

What is driving this change?  The commit message isn't quite correct as MPIC_LARGE_VECTORS is about the # of IRQs, not the fact that vector field is 16-bits.

> 
> Signed-off-by: Varun Sethi <Varun.Sethi at freescale.com>
> ---
> arch/powerpc/sysdev/mpic.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index 8be1ea2..33520dd 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -1191,7 +1191,7 @@ struct mpic * __init mpic_alloc(struct device_node *node,
> 	if (of_get_property(node, "single-cpu-affinity", NULL))
> 		flags |= MPIC_SINGLE_DEST_CPU;
> 	if (of_device_is_compatible(node, "fsl,mpic"))
> -		flags |= MPIC_FSL;
> +		flags |= MPIC_FSL | MPIC_LARGE_VECTORS;
> 
> 	mpic = kzalloc(sizeof(struct mpic), GFP_KERNEL);
> 	if (mpic == NULL)
> -- 
> 1.7.2.2
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev



More information about the Linuxppc-dev mailing list