[PATCH] powerpc/85xx: don't call of_platform_bus_probe() twice
galak at kernel.crashing.org
Sat Mar 17 07:46:07 EST 2012
On Nov 30, 2011, at 10:19 AM, Timur Tabi wrote:
> Commit 46d026ac ("powerpc/85xx: consolidate of_platform_bus_probe calls")
> replaced platform-specific of_device_id tables with a single function
> that probes the most of the busses in 85xx device trees. If a specific
> platform needed additional busses probed, then it could call
> of_platform_bus_probe() again. Typically, the additional platform-specific
> busses are children of existing busses that have already been probed.
> of_platform_bus_probe() does not handle those child busses automatically.
> Unfortunately, this doesn't actually work. The second (platform-specific)
> call to of_platform_bus_probe() never finds any of the busses it's asked
> to find.
> To remedy this, the platform-specific of_device_id tables are eliminated,
> and their entries are merged into mpc85xx_common_ids, so that all busses
> are probed at once.
> Signed-off-by: Timur Tabi <timur at freescale.com>
> arch/powerpc/platforms/85xx/common.c | 6 ++++++
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 11 +----------
> arch/powerpc/platforms/85xx/p1022_ds.c | 13 +------------
> 3 files changed, 8 insertions(+), 22 deletions(-)
This seems like paper taping over the real issue. We should be able to call of_platform_bus_probe() multiple times.
More information about the Linuxppc-dev