[PATCH 2/9] powerpc/mpc85xxcds: Fix PCI I/O space resource of PCI bridge

[Kumar Gala]

On Mar 7, 2012, at 3:31 AM, Zhao Chenhui-B35336 wrote:

>>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
>>> index 40f03da..c009c5b 100644
>>> --- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c
>>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
>>> @@ -3,7 +3,7 @@
>>> *
>>> * Maintained by Kumar Gala (see MAINTAINERS for contact information)
>>> *
>>> - * Copyright 2005 Freescale Semiconductor Inc.
>>> + * Copyright 2005, 2011-2012 Freescale Semiconductor Inc.
>>> *
>>> * This program is free software; you can redistribute  it and/or modify it
>>> * under  the terms of  the GNU General  Public License as published by the
>>> @@ -158,6 +158,31 @@ DECLARE_PCI_FIXUP_EARLY(0x1957, 0x3fff, skip_fake_bridge);
>>> DECLARE_PCI_FIXUP_EARLY(0x3fff, 0x1957, skip_fake_bridge);
>>> DECLARE_PCI_FIXUP_EARLY(0xff3f, 0x5719, skip_fake_bridge);
>>> 
>>> +/*
>>> + * Fix Tsi310 PCI-X bridge resource.
>>> + * Force the bridge to open a window from 0x0000-0x1fff in PCI I/O space.
>>> + * This allows legacy I/O(i8259, etc) on the VIA southbridge to be accessed.
>>> + */
>> 
>> This comment and the code don't make sense.  Why is the bridge described as Tsi310 in comments but the
>> vendor ID is IBM ?
> 
> This chip is from IBM originally, and bought by IDT.
> The vendor ID is IBM, but the part number is Tsi310(IDT).
> 

Ok, we should probably call it PCI_DEVICE_ID_..._TSI310

- k