[PATCH] USB: FHCI: Reusing the QUICC Engine USB Controller registers struct from immap_qe.h.

Kumar Gala galak at kernel.crashing.org
Wed Jun 20 06:45:43 EST 2012


On Jun 19, 2012, at 8:12 AM, Guilherme Maciel Ferreira wrote:

> The struct fhci_regs (in fhci.h) is basically a redefinition
> of the struct qe_usb_ctlr (in immap_qe.h). The later struct is
> preferrable once it uses the registers names found at the
> Freescale's QUICC Engine manual. Thus it is easier to map the
> driver to the manual.
> 
> Also, the FHCI driver uses the USB controller registers, so
> the name qe_usb_ctlr maps better to the hardware than fhci_regs.
> 
> Signed-off-by: Guilherme Maciel Ferreira <guilherme.maciel.ferreira at gmail.com>
> ---
> drivers/usb/host/fhci-dbg.c   |   12 ++++++------
> drivers/usb/host/fhci-hcd.c   |   32 ++++++++++++++++----------------
> drivers/usb/host/fhci-hub.c   |   16 ++++++++--------
> drivers/usb/host/fhci-sched.c |   30 +++++++++++++++---------------
> drivers/usb/host/fhci-tds.c   |   14 +++++++-------
> drivers/usb/host/fhci.h       |   22 ++--------------------
> 6 files changed, 54 insertions(+), 72 deletions(-)

This should be sent to the USB maintainers.

- k


More information about the Linuxppc-dev mailing list