[PATCH] powerpc/44x: Support OCM(On Chip Memory) for APM821xx SoC and Bluestone board

Josh Boyer jwboyer at gmail.com
Wed Jun 13 11:22:12 EST 2012

On Tue, Jun 12, 2012 at 8:40 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Tue, 2012-06-12 at 17:26 +0700, Vinh Huu Tuong Nguyen wrote:
>> > -----Original Message-----
>> > From: Vinh Nguyen Huu Tuong [mailto:vhtnguyen at apm.com]
>> > Sent: Monday, May 07, 2012 10:53 AM
>> > To: Benjamin Herrenschmidt; Paul Mackerras; Josh Boyer; Matt Porter;
>> > Grant Likely; Rob Herring; Duc Dang; David S. Miller; Kumar Gala; Li
>> > Yang; Ashish Kalra; Anatolij Gustschin; Liu Gang; linuxppc-
>> > dev at lists.ozlabs.org; linux-kernel at vger.kernel.org; devicetree-
>> > discuss at lists.ozlabs.org
>> > Cc: Vinh Nguyen Huu Tuong
>> > Subject: [PATCH] powerpc/44x: Support OCM(On Chip Memory) for APM821xx
>> > SoC and Bluestone board
> Such a CC list won't get you any good will. Send it only to the relevant
> mailing lists with possibly the -one- concerned maintainer on CC. I
> doubt Dave Miller or Matt Porter give any damn about those patches.
> As for why it wasn't reviewed yet, well, reviewers are a finite resource
> with limited time dedicated to it. If the patch is properly formed and
> was posted to the linuxppc-dev at ozlabs.org, it should be tracked on
> patchwork.ozlabs.org and won't be lost. Double check it's there (if it's
> not, then the patch was probably corrupt).

It's there.  I just missed it until today.  My apologies Vinh.  I'll
do a more formal review tomorrow, but at first glance I'm concerned
with the sysfs usage.  The files in sysfs are supposed to be one file
per value, and you see to have something akin to /proc/meminfo in the
sysfs file being created.  Perhaps that would be better either split
into unique file names per field in sysfs, or in a debugfs file

Again, I'll review more closely tomrorow.


More information about the Linuxppc-dev mailing list