Q: a_ops->readpage() && struct file

Oleg Nesterov oleg at redhat.com
Tue Jun 12 05:09:02 EST 2012

On 06/11, Oleg Nesterov wrote:
> Note also that we should move this !UPROBE_COPY_INSN from
> install_breakpoint() to somewhere near alloc_uprobe().

The main problem is, uprobe_register() doesn't have struct file
for read_mapping_page().

Stupid question. I'm afraid the answer is "no" but I'll ask anyway.
Is it safe to pass filp == NULL to mapping->readpage()? In fact
I do not understand why it needs "struct file*" and I do not see
any example of actual usage. Yes, I didn't try to grep very much
and I understand that the filesystem can do something special.
Say it can use file->private_data...

However. There is read_cache_page_gfp() which does use
a_ops->readpage(filp => NULL), and the comment says nothing about
the riskiness.

If not, is there any other way
uprobe_register(struct inode *inode, loff_t offset) can read the
page at this offset?

And btw, read_mapping_page() accepts "void *data". Why? it uses
filler == a_ops->readpage, it shouldn't accept anything but file

Please help, I know nothing about vfs.


More information about the Linuxppc-dev mailing list